Technical Articles
How to check your SAP Queries for SAP S/4HANA readiness
If you are going to convert your SAP Business Suite system to SAP S/4HANA and want to check your custom code, you use one of the ABAP Test Cockpit check variants like S4HANA_READINESS_REMOTE or S4HANA_READINESS_1909 for example (see also the blog SAP S/4HANA System Conversion – Custom code adaptation process).
So far the check for SAP Query was not a part of the SAP S/4HANA readiness ATC check variants. But now you can check your custom SAP Queries for SAP S/4HANA readiness after implementing the corresponding SAP Note 2942419 – Include ATC check ‘S/4HANA: Readiness Check for SAP Queries’ to the SAP S/4HANA custom code checks, which is available for all SAP_BASIS >=7.52 releases.
After this you will get the new SAP Query check into all your SAP S/4HANA readiness check variants:
Consequently after checking your custom code containing SAP Queries with the updated SAP S/4HANA readiness check variant you will get the ATC findings also for your custom SAP Queries in case they use the SAP standard objects, which were simplified in SAP S/4HANA.
In the following example the SAP Fiori App Custom Code Migration executes an ATC run over the custom code in an ERP system and the SAP Query check reports the ATC findings in the result list:
In the details of the corresponding ATC finding you can track the reason: in the custom Infoset S4H_DEMO_INFOSET the table BSEG is used, which is simplified in SAP S/4HANA according to the SAP Note 2431747:
Thanks, Olga! That's helpful and good to know!
I take it that it's enough to apply the OSS-Note in a central ATC-system with NW 7.52 and to then use the S/4HANA Readiness check variant for objects in the satellite systems which are on NW 7.50 SP16?
Cheers
Bärbel
Hi Bärbel,
exactly: you just apply the note in the central ATC check system and use your central ATC check variant for S/4HANA Readiness as before (for checking your remote NW 7.50 systems) : the note will enrich the S/4HANA Readiness check variant with the SAP Query check.
Best,
Olga.
Hi Olga,
in the meantime we applied the OSS-Note in our central ATC-system but we don’t yet see the option for the Query check under the node for S/4HANA-Readiness checks, regardless of the Check Variant we look at (my expectation was that it would show up within the highlighted section):
We already opened an incident but I’d like to make sure that we are looking in the right place for this new option to show up.
Thanks much and cheers
Bärbel
Hi Bärbel,
yes, it's the correct place for the SAP Query check.
Best,
Olga.
Turns out that the OSS-Note had been updated in the meantime and (parts of it) needed to be "re-implemented". Once done, the new option for SAP-queries shows up in the list of S/4HANA Readiness checks in the various check variants.
Thanks much and Cheers
Bärbel
Thanks Olga. I implemented the Note and Prerequisites, but can't finish the implementation as I have a syntax error in class CL_CI_TEST_SAP_QUERY_S4H_READY method get_detail due to missing data element sca_reference_obj_name. I can't find any other notes or manual activitites on OSS mentioning this, could you check? Or do you prefer that I create a message on OSS?
Regards,
Wouter
Hi Wouter,
please open the OSS message regarding this issue.
Best Regards,
Olga.
Hi Olga.
Very good to know this function .
Can this variant perform code check which developed inside of Custom Query also ?
Regards,
LJ
Hi Longjie,
this check does exactly this: checks code inside of your custom SAP Queries for SAP S/4HANA readiness.
Regards,
Olga.
Hi Olga.
Perfect . I just want make sure it is not only check simplification table in infoset .
Regards,
LJ
Hello Olga,
I am facing dump saying "Function module "IQAPI_CHECK_INFOSET" not found." while running in local S/4 HANA 1909 system (not with Central ATC). Could you suggest if I am missing something. If not, i will raise OSS.
Thanks in advance !
Regards,
Nilesh
Hi Nilesh,
you are missing the implementation of the SAP Note 2889487.
Regards,
Olga.
Hello Olga,
Yes, it worked. Thank you !
Regards,
Nilesh.
Hello Olga,
it seems that with S4HANA_READINESS_SAPQUERY check variant no HANA DB functional checks are executed.
How can I check SAP queries for HANA DB functional issues?
Best regards,
Lars
Hello Lars,
HANA DB functional checks are also included in to S/4HANA readiness check for SAP Queries.
Please consider the following. In the SAP Query we have 2 so-called work areas: The “global area” is cross-client and the query objects have TADIR entries and can therefore be handled by the ATC check.The other is the so-called “standard area”. This is client-specific and therefore there are no TADIR entries. These (mostly historical) objects cannot be checked by the ATC check. There is then the report RSAQ_CHECK_S4H_READY must be executed. See also the SAP Note 2857006.
Kind Regards,
Olga.
Hello Olga,
thanks for your answer. We have a lot of queries in the standard area to check. So according to your answer not ATC check is possible for those queries.
We executed the report RSAQ_CHECK_S4H_READY and found out, that this report just checks the queries for usage of simplified database tables, no futher hana db or s/4hana checks were executed.
So my conslusion is, that for queries in the standard area no furhter code checks are possible, just the check for simplified database tables.
Is that correct?
Best regards,
Lars
Hi Lars,
meanwhile I talked to our SAP Query development. Their statement is, that both the S4HANA_READINESS_SAPQUERY check variant or the report RSAQ_CHECK_S4H_READY are sufficient for the S/4HANA readiness checks of SAP queries. Other HANA DB checks or S/4HANA checks are not relevant since no custom code which accesses DB data should be developed within SAP queries.
Best regards,
Olga.
Hello Olga,
thanks for that information. But this means (as supposed above) that there is no possibility to check custom code in SAP queries for missing ORDER BY statements, if there is custom code accessing the SAP database.
Best regards,
Lars
Hi,
Once these impacts on SAP queries are detected, is there any tool to remediate affected SAP Queries ? or the only option is to create a new infoset / query using new data model tables ?
Thanks,
Francisco
Hi Francisco,
there is no tool support for remediation of SAP Queries.
Kind Regards,
Olga.
Hello Olga,
Are these correct?
ATC supports client-independent (global) SAP queries.
ATC does not support client-dependent SAP queries.
regards,
Hiroshi
Hi Hiroshi,
yes, it is correct, to check client-dependent SAP Queries you can use the report RSAQ_CHECK_S4H_READY (see also the SAP Note 2857006 - SAP S/4HANA: Readiness check for SAP queries
Kind Regards,
Olga.
Hello Olga,
Hope you are fine. I am facing an issue in ATC run for SAP Query. My system version is SAP_BASIS 756. When I schedule the ATC for SAP queries with variants: S4HANA_READINESS_SAPQUERY or S4HANA_READINESS_2021 the result is not containing any errors.
I tried with individual generated programs of queries but same result. Since there is no TADIR entries for these generated program, no error is being reported.
Could you please point out if I am missing any point?
Thanks in advance.
Rohit Tiwari
Hi Rohit Tiwari,
have you checked, if your S4HANA_READINESS_2021 check variant contains the ATC check for SAP Query? If yes, then maybe your custom SAP queries don't have any issues with regard to the S/4HANA simplifications?
Kind Regards,
Olga.