Skip to Content
Technical Articles
Author's profile photo Olga Dolinskaja

Remote Code Analysis in ATC – Working efficiently with ATC Result List

This is the eighth blog of the blog series about Remote Code Analysis in ABAP Test Cockpit (ATC).

See also blogs:


Motivation

After you execute an ATC check run, the ATC findings are reported in the prioritized work list. Fast and efficient processing of the ATC result is essential for best quality assurance of your code. This blog outlines and highlights the most helpful features of the ATC result view to make your work with it more effective.

There are two ways to look at ATC results.

Using filters

First, you can filter results using either the quick filter at the top of the ATC result and just specify the search fields or the advanced filter with more capabilities (and even save it as a variant for the ATC result display).

The screenshot below demonstrates how to restrict the ATC result view to the ATC findings in the package TEST_S4H_CCM using the quick filter.

 

Using Statistics View

Second, you can use the ATC Statistics View to group ATC findings by different statistics. Single available statistics are extremely helpful for static code analysis within custom code adaptation projects for SAP S/4HANA, for best focus on the simplifications in SAP S/4HANA.

In the ATC result view you can open the Statistics View by clicking the “Statistics View” button:

In the Statistics View the ATC result is grouped by the ATC checks. For example (see screenshot below) to display all ATC findings related to the SELECT statements without ORDER BY clause you need just to double click the relevant ATC check in the selection tree.

You can also list the findings related to the specific ATC check message. Just open the tree node of the particular ATC check, choose and double click the ATC message:

Of course, from the details view you can navigate directly to the corresponding source code row by clicking on the Object Name:

 

Statistics View by Component ID

Choosing Statistics View by Component ID (available with AS ABAP 7.52) you can e.g. find out in which area of business application (SD, FIN) the SAP S/4HANA simplification comes:

 

Statistics View by Referenced Object

Choosing Statistics View by Referenced Object (available with AS ABAP 7.52) offers e.g. a good overview about the simplified objects in SAP S/4HANA (like MATNR, VBUK, VBTYP etc.)

 

Statistics View by SAP Note

Choosing the Statistics View by SAP Note number (available with AS ABAP 7.52) offers you e.g. a good overview over the SAP S/4HANA simplification related SAP Notes:

It allows you to focus on the ATC findings related to a particular SAP Note. Like e.g. the transactions for entering and displaying goods movements (material documents) – called “MB transactions” were decommissioned in SAP S/4HANA and if they were used in the custom code, they must be replaced by the transaction MIGO.

Statistics View by Contact Person

Choosing the Statistics View by contact person offers you the ATC checks grouped by the author (or responsible person) of the object:

And finally, just to give you a short outlook in the future:  we currently work on the using the last changer of a source as a statistics criterion. This has been requested by many customers because the author of an object is often no longer in the company or meanwhile cares about something else. Stay turned!

 

Assigned Tags

      43 Comments
      You must be Logged on to comment or reply to a post.
      Author's profile photo Uwe Fetzer
      Uwe Fetzer

      Hi Olga,

      thank you for this overview.

      I hope the coming "Statistics by last changer" we can implement via SAP note in 7.51 (pretty please... 🙂 ).

      Cheers, Uwe

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      I second Uwe's comment. We are currently trying to achieve this via the user exits (see comment on your FAQ blog) so can you confirm when and in which version this functionality will be delivered.

      Thanks

      Ian

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

       

      Any news on the 'Statistics by last changer' option?

       

      Regards

      Ian

       

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      this feature is currently in development.

      Regards,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Thanks Olga.

       

      Are you able to confirm whether this will be a 7.52 feature only or backported to 7.51 as well?

       

      Regards

      Ian

       

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      no, unfortunately I can't confirm this. Currently the "Statistics by last changer" will be implemented only for the next major ABAP release.

      Regards,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      Can you tell me where the template is for the emails?  When emailing out from the Central ATC, the standard text says to logon to the central system but I do not want them to do this, I want them to logon to the satellite system.

      Thanks

      Ian

      Regards

      Ian

       

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      in the "Send E-Mails" popup there is the button to enter an email text. Have you tried it?

      Best Regards,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

       

      Yes I have but it would be pretty tedious to amend the text for every email I send ?

       

      Thanks

      Ian

       

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      Just wondering if there was an update on the 'Statistics by last changer' implementation?

       

      Thanks

      Ian

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      it is available with S/4HANA 1809/AS ABAP 7.53 SP00 + correction in the SAP Note https://launchpad.support.sap.com/#/notes/2656578

      Regards,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Thanks Olga.  I'll see if I can get an upgrade then.

       

      Regards

      Ian

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      Is there any other functionality in 7.53 that is specific to the Central ATC btw?

       

      Regards

      Ian

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      there are some improvements in ATC like e.g. further remote-enabling of ATC checks, immediate automatic email notification after ATC run and after exemptions, transport stop only for Prio 1 ATC findings, BAdI to filter object set at transport release.

      Regards,

      Olga.

       

      Author's profile photo Emily Celen
      Emily Celen

      Hi Olga,

      how can I activate the immediate automatic email notification after ATC run? Would be great to get a list of all findings as email after ATC run finished.

      Regards

      Emily

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Emily,

      look here: https://help.sap.com/viewer/ba879a6e2ea04d9bb94c7ccd7cdac446/201809.000/en-US/3d797520deb341fbaba53c8986a93e46.html

      Regards,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      Sounds good. I have my upgrade planned in for w/c 18th Feb. so shall look forward to checking all the new functionality out.

       

      Regards

      Ian

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      Rereading your post and also getting input from the basis team here suggests that this is only available for S/4HANA 1809? Or is also available for NW AS ABAP 7.52 plus a support pack? We cannot find it in the PAM anywhere else apart from under S/4HANA 1809.

      Thanks

      Ian

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      I've just you document - https://www.sap.com/documents/2018/10/06ffdf13-207d-0010-87a3-c30de2ffd8ff.html

      which seems as though there is no upgrade path from 7.52 to 7.53.

       

      Can you confirm?

      Thanks

      Ian

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      I raised an SAP incident for this and it is confirmed that there is no upgrade path as 7.53 is not available as a standalone product.  This I find rather surprising and disappointing since the Central ATC is suggested to be used as a standalone system. Why would we need a HANA db and the associated cost for this system?

      Will any of the newer functionality that made its way into the 7.53 release be backported for those of us that will be 'stuck' unless we move to S/4?

      Regards

      Ian

      Author's profile photo Michael Kretz
      Michael Kretz

      Is there an reply here? I am interested, too, and not eveybody should be forced to raise an OSS ticket for this obvious requirement.

      I would appreciate a comprehensive statement here or a link to a document.

      Related question: does a central ATC on 7.52/7.53 require a SAP HANA DB?

      Author's profile photo Michael Kretz
      Michael Kretz

      We have an ATC on 7.52, but we do not see the statistics view "SAP Note Number". Is there a note to include this view into our installation?

       

      Thanks,

      Michael

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Michael,

      if you set up and configured the remote ATC 7.52 inkl. all SAP Notes as described in the https://blogs.sap.com/2016/12/13/remote-code-analysis-in-atc-technical-setup-step-by-step/, then the Statistics by SAP Note number should be there.

      Caution: it is not a separate view, it is just the additional selection criterion in the ATC StatisticsView under "Choose Statistics".

      Regards,

      Olga.

      Author's profile photo Michael Kretz
      Michael Kretz

      Yes, I know from other installations .

      Still it is not there in the new one, and I would appreciate to find a Note number or any hint on this. The blog you mention is the well known one but I don't find any help to my specific problem there.

       

      Thanks for helping

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Michael,

      there is no dedicated SAP Note on this: the new StatisticsView option must be in the ATC in 7.52 system. Please open the OSS message to SAP to evaluate your particular problem.

      Regards,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      Do I recall you mentioning that in 7.53 there are Fiori apps for displaying Central ATC data?

      Regards

      Ian

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      the SAP Fiori App (based on SAP S/4HANA 1809)  is for the custom code analysis for SAP S/4HANA. See also https://blogs.sap.com/2019/02/27/custom-code-analysis-for-sap-s4hana-with-sap-fiori-app-custom-code-migration/ for details.

      Regards,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      Ok. Thanks for confirming. I assume that no analysis apps will be imminent then and I will continue to build my own.

      This is the piece that is really missing in the Central ATC. A nice dashboard would work wonders 🙂

      Cheers

      Ian

       

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

       

      I seem to recall that by clicking the 'Show additional Fields' button on the result list that the line number is displayed as well. Is this correct?  Currrently when I press this button, nothing happens!

       

      Thanks

      Ian

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      yes, by clicking the ‘Show additional Fields’ button on the result list the line number must be displayed as well. If it doesn't happen you could e.g. open the OSS message.

      Regards,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Thanks for confirming Olga.

       

      Seems it works ok for a colleague. Must be my setup. Bizarrre!

       

      Regards

      Ian

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      When executing a scan via SE80 in the remote system, the results are stored in the remote system and not the central system. However, I do sometimes see the results of remote scans within SE80 and the Manage Results section of the ATC within the central system.

      What is determining where the results are stored?

      Thanks

      Ian

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      do you mean remote ATC developer scenario: execute check on the dev system but use for the check the remote ATC and the check variant from the central ATC system? Then the results should be stored on both systems: dev system and central ATC system.

      Regards,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

       

      Yes to the scenario you describe. We are not seeing the results in the central system all the time. A few arrive by mostly not.

      Is there anything I can check?

       

      Thanks

      Ian

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

       

      A second query for today regarding DDIC type scans.  When including the DDIC: DB Tables (Logging Check) - (CL_CI_DDIC_CHECK_LOGGING) rom the Security collector, I get a dump relating to the execution of the SCI_EXECUTE_TEST FM. This is because it want to use a BACK RFC destination and currently there isn't one.

      Why does it need to use an RFC destination if the FM is being called locally?

      Thanks

      Ian

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      if the check is called locally, then the SCI_EXECUTE_TEST should not be called at all. Could you please provide more information: your check variant and the dump?

      Regards,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

      I think I have not been very clear with you. The scan is initiated via the remote system and the SCI_EXECUTE_TEST FM is called in the central system. The RFC destination is set to BACK which I now understand to be an internal RFC destination. I have checked since and the BACK RFC is there but it refers to an invalid memory area. Either way, since the FM is called in the same system, why the need for the BACK RFC anyway?

       

       

      Thanks

      Ian

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      please clarify the following: do you scan your remote system from the central ATC check system or you execute ATC check locally on the remote system but using the remote check variant on the central ATC check system (developer scenario)?

      Thanks,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

       

      The second option.  We execute the ATC check locally on the remote system but using the remote check variant on the central ATC check system (developer scenario)?

       

      Thanks

      Ian

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      I talked to the ATC colleagues. Please open a ticket to SAP for this issue.

      Regards,

      Olga.

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

       

      Ok. Will do.

       

      Thanks

      Ian

      Author's profile photo Ian Stubbings
      Ian Stubbings

      Hi Olga

       

      Another issue/question this time related to the options wwhen schedulng a job.

       

       

      For the two options above, I would not expect exempted results to be considered but they are for both.  Is there any way to filter them out? Otherwise the develoers will be bombarded for findings thatare already exempted and the statistics indlude thousands of finding we don't care about.

       

      Regards

      Ian

      Author's profile photo Olga Dolinskaja
      Olga Dolinskaja
      Blog Post Author

      Hi Ian,

      the rule is the following: if exemptions are requested for the findings (but not yet approved), the findings will still be considered for notifications. If the findings are already exempted, they should not appear in notifications. If you still get notifications for the findings, which are already exempted, please open a ticket to SAP.

      Regards,

      Olga.